Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add start script #22

Merged
merged 3 commits into from
Sep 29, 2020
Merged

add start script #22

merged 3 commits into from
Sep 29, 2020

Conversation

akash1810
Copy link
Member

#18 take 2.

What does this change?

Adds a start script with an option to ignore an already running instance of nginx.

This will be useful when scripting the starting of a service.

Let's say we have the following in the file script/start:

#!/usr/bin/env bash

set -e

sbt run

If the service requires an nginx reverse proxy running, we'd need to separately ensure it's running. This PR allows us to further script nginx, script/start becomes:

#!/usr/bin/env bash

set -e

dev-nginx start -g
sbt run

How can we measure success?

Simplifying the process of starting an application locally.

Adds a start script with an option to ignore an already running instance of nginx.

This will be useful when scripting the starting of a service as it can become:

```
dev-nginx start -i
sbt run
```

This helps avoid the situation where you receive an error such as `ERR_CONNECTION_REFUSED` in the browser as you've forgotten to manually start nginx.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants