Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide more crossword customisation options #1850

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Dec 12, 2024

What are you changing?

  • calculate gridWidth in the main Crossword component and pass it to custom layouts
  • wrap the clues heading in custom Header, rather than the other way around

Why?

so that consumers can layout custom pages more easily. wrapping the clues heading in custom Header means we lose the ability to set custom text, but gain the ability to layout the component at the same level as the clues beneath, which gives you more flexiblity than simply styling the contents.

@sndrs sndrs requested a review from a team as a code owner December 12, 2024 15:27
Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 6a22458

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Dec 12, 2024
@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Dec 12, 2024
@sndrs sndrs added this to the Decommission Frontend Rendering milestone Dec 12, 2024
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs self-assigned this Dec 12, 2024
@sndrs sndrs requested a review from oliverabrahams December 12, 2024 15:27
@sndrs sndrs changed the title pass grid width to Layout component provide more customisation options Dec 12, 2024
@sndrs sndrs changed the title provide more customisation options provide more crossword customisation options Dec 12, 2024
@sndrs sndrs force-pushed the sndrs/xwd/provide-grid-width branch from 8dbb84b to 6a22458 Compare December 12, 2024 16:42
@sndrs sndrs added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Dec 12, 2024
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@sndrs sndrs merged commit c486122 into main Dec 12, 2024
25 checks passed
@sndrs sndrs deleted the sndrs/xwd/provide-grid-width branch December 12, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐥 Canaries Triggers canary releases of any packages with changesets waiting. 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants