Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storybookBaseDir to Chromatic workflow #1102

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

joecowton1
Copy link
Contributor

What are you changing?

  • adding a storybookBaseDir to the Chromatic workflow.

Why?

  • each of the individual storybooks is nested within libs/@guardian/[projectName], we need to tell chromatic where to find these.
  • Many thanks to Reuben at Chromatic for suggesting this fix.

@joecowton1 joecowton1 requested a review from a team as a code owner January 23, 2024 08:34
Copy link

changeset-bot bot commented Jan 23, 2024

⚠️ No Changeset found

Latest commit: 1e8522e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joecowton1 joecowton1 added the run_chromatic Runs chromatic when label is applied label Jan 23, 2024
@joecowton1 joecowton1 merged commit ecee45c into main Jan 23, 2024
25 checks passed
@joecowton1 joecowton1 deleted the jc/chromatic-fix branch January 23, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant