Update to theme prop proposal

[sndrs]

What are you changing?

• create one choiceCardTheme type
• renames some of the theme munging stuff
• requires a theme to be passed the styles functions (rather than defaulting - let's default in one place)
• adds types the to story to clean up the red squiggles

[changeset-bot]

⚠️ No Changeset found

Latest commit: a59cbe7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[oliverabrahams]

is the theme: choiceCardDark better if we consider this as part of the documentation for this component. It is the "recommended" way of theming

[sndrs]

yeah i think it would be if we had a dark theme for this component. in that case we'd want to explicit provide a story for that (and any other built-in themes).

the reason i removed it here is because we don't (yet?) have that, and so hopefully this makes clear it's a made up example of one way of using the prop, rather than implying there was a dark theme you can use

[oliverabrahams]

That makes sense. Happy to go with that, we could change the colours to come from the palette because that may be more how we want the prop used. I am happy to do that once this is merged tho.

[sndrs]

yeah i think we do want that, but part of me felt that because right now you can do the 'wrong' thing, we should have a story that does that, then have it break when we fix it. maybe that's the wrong approach.

but maybe we shoudl fix the types in foundations so you can't?

[oliverabrahams]

LGTM