Remove publish false to fix thrift package release #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divs-B
added a commit
that referenced
this pull request
Mar 21, 2024
We have encountered an issue of content-entity-thrift not being released after the work in PR #32 to maven due to error in making its publish to false which is corrected in the PR here #36 To test this we are trying manually version update to the one after which content-entity-thrift didn't get release.
|
Note that because an additional artifact is now being published (the |
Divs-B
added a commit
that referenced
this pull request
Mar 26, 2024
Suggested by Roberto we can disable the releases checks to make succesful release this time, the release process is currently trying to find thrift latest release of 3.0.1 which is not available hence we will disable release comparison and make the release and then will enable again once releases goes well. #36 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
During implementing the gha scala llibrary release process in PR #32 , mistakenly
thriftpackage was made publish to false #32 (comment) due to which thrift package didn't publish to maven during the release of v3.0.1. This change will back the original condition of publishing.How to test
By making release after merging this change.
How can we measure success?
content-entity-thriftshould also make its way to maven at https://repo1.maven.org/maven2/com/gu/content-entity-thrift/