chore: Extending "@guardian/tsconfig" in tsconfig #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9be4825 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
akinsola-guardian
changed the title
sndrs
reviewed
Nov 3, 2023
cdk/tsconfig.json
Outdated
| "outDir": "dist", | ||
| "allowJs": true, | ||
| "isolatedModules": true, | ||
| "module": "ES6", |
There was a problem hiding this comment.
do you need this value specifically? the default from the config is esnext
There was a problem hiding this comment.
I've removed the module from this tsconfig.json file. However, I had to add the "module": "commonjs" to monitoring/tsconfig.json
joecowton1
approved these changes
Nov 7, 2023
joecowton1
previously approved these changes
Nov 7, 2023
|
I believe this has produced an invalid output for the types, as this version of the library fails to compile with TypeScript in frontend: guardian/frontend#26680 It seems like the Consent State object is now typed as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
As recommended by Joe Cowton, I've installed "@guardian/tsconfig" and extended it in the tsconfig.json.
Why?
To ensure that CMP linting standards align with the patterns recommended Client Side