Add The Trade Desk to prebid #1773
Merged
+91
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e5ea9e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ad load time test resultsFor Test conditions:
|
Jakeii
force-pushed
the
jlk/add-tdd-to-prebid
branch
from
aade0bc to
13d1f2f
Compare
Jakeii
force-pushed
the
jlk/add-tdd-to-prebid
branch
from
53ff434 to
e746bd2
Compare
Jakeii
commented
Jan 31, 2025
| @@ -203,6 +202,8 @@ class PrebidAdUnit { | |||
| }, | |||
| }; | |||
|
|
|||
| this.bids = bids(advert.id, slot.sizes, pageTargeting, this.gpid); | |||
There was a problem hiding this comment.
trade desk uses gpid as the placementId so need to pass it through
emma-imber
approved these changes
Jan 31, 2025
Co-authored-by: Emma Imber <[email protected]>
Co-authored-by: Emma Imber <[email protected]>
Thank you! |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds new config for new prebid bidder The Trade Desk.
The line-items have already been setup. And I've tested that the new module is requesting bids.
This is behind a 0% test for the commercial and the trade desk folks to test also.