feat: Expose components of ecs-task, enforce read only root filesystem #2545
+16
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c964005 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
philmcmahon
force-pushed
the
pm-expose-task-containerdefinition
branch
from
263e613 to
a11349f
Compare
akash1810
approved these changes
Dec 20, 2024
Co-authored-by: Akash Askoolum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Replaces #2544 following a great suggestion from @akash1810.
This PR enforces readonlyRootFilesystem. This change may require apps that use this pattern to mount a volume onto the container to use for writing application data to disk. Exposing the container definition and task definition makes this possible. It should also make it easier to work with this pattern without having to keep making changes to the core GuCDK library.
How to test
I've tested this in Lurch by referencing this branch