vpc construct: only try setting context if unset #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently a single stack cannot create multiple vpcs, as each will try to set the context itself, and the subsequent creations will throw errors like Cannot set context after children have been added: MyVpc
🦋 Changeset detectedLatest commit: 8e8a20f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
akash1810
approved these changes
Sep 3, 2024
| "eu-west-1b", | ||
| "eu-west-1c", | ||
| ]); | ||
| const contextKey = `availability-zones:account=${account}:region=eu-west-1`; |
There was a problem hiding this comment.
Not for this PR necessarily, but I wonder why the region has been hard-coded here, rather than this.region?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
currently a single stack cannot create multiple vpcs, as each will try to set the context itself, and the subsequent creations will throw errors like
Instead, only attempt to set the context if it is unset
How to test
Run the provided unit test
How can we measure success?
Stacks in the account setup repo can succeed even if one account attempts to create two "new VPCs".
Have we considered potential risks?
I don't really understand this error, I may have missed a more correct fix for this situation.
Checklist
Footnotes
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩