Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump yargs and @types/yargs #2047

Merged
merged 2 commits into from
Oct 10, 2023
Merged

chore(deps): bump yargs and @types/yargs #2047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fb0664
chore(deps): bump yargs and @types/yargs
dependabot[bot] Oct 5, 2023
73ccd81
refactor(cli): Cast arguments to help yargs and TypeScript
akash1810 Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@types/lodash.kebabcase": "^4.1.7",
"@types/lodash.upperfirst": "^4.3.7",
"@types/node": "20.8.2",
"@types/yargs": "^17.0.19",
"@types/yargs": "^17.0.26",
"aws-cdk": "2.95.1",
"cz-conventional-changelog": "^3.3.0",
"eslint": "^8.50.0",
Expand Down Expand Up @@ -66,7 +66,7 @@
"lodash.kebabcase": "^4.1.1",
"lodash.upperfirst": "^4.3.1",
"read-pkg-up": "7.0.1",
"yargs": "^17.6.2"
"yargs": "^17.7.2"
},
"peerDependencies": {
"aws-cdk": "2.95.1",
Expand Down
17 changes: 13 additions & 4 deletions src/bin/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,21 @@ parseCommandLineArguments()
return awsCdkVersionCommand();
}
case Commands.AccountReadiness: {
const { profile, region } = argv;
return accountReadinessCommand({ credentialProvider: awsCredentialProviderChain(profile), region });
// TODO remove casting as yargs should be able to infer the type of the options
const profile = argv.profile as string;
const region = argv.region as string;
return accountReadinessCommand({ credentialProvider: awsCredentialProviderChain(profile), region: region });
}
case Commands.New: {
const { init, app, stack, yamlTemplateLocation, stage, packageManager } = argv;
const stages = stage.map((_) => (_ as string).toUpperCase());
// TODO remove casting as yargs should be able to infer the type of the options
const init = argv.init as boolean;
const app = argv.app as string;
const stack = argv.stack as string;
const yamlTemplateLocation = argv["yaml-template-location"] as string | undefined;
const stage = argv.stage as string[];
const packageManager = argv["package-manager"] as string;

const stages = stage.map((_) => _.toUpperCase());
return newCdkProject({
init,
app,
Expand Down