-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Add 4xx alarms as an optional parameter to ec2 base alarm config
Being alerted to high volumes of 404 requests is arguably a common pattern that is useful to extend to CDK. We've added this to another project where it would have allowed us to catch a production issue, so contributing upstream to gauge if useful for others. This change adds an optional http4xxAlarm to the `Alarms` type on the `GuEc2AppProps` interface, as it is perhaps not as critical to consider as the 5xx events, but still hopefully a useful affordance.
- Loading branch information
Showing
6 changed files
with
365 additions
and
5 deletions.
There are no files selected for viewing
216 changes: 216 additions & 0 deletions
216
src/constructs/cloudwatch/__snapshots__/ec2-alarms.test.ts.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.