Skip to content

Commit

Permalink
fix(deps): peer dependencies are never direct
Browse files Browse the repository at this point in the history
there’s no value in having the same dependency
declared as both direct and peer
  • Loading branch information
mxdvl committed Jan 18, 2024
1 parent edf26ee commit a08c35c
Show file tree
Hide file tree
Showing 3 changed files with 56 additions and 8 deletions.
9 changes: 9 additions & 0 deletions .changeset/chilled-jeans-wink.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@guardian/cdk": patch
---

Remove direct dependencies that should be peer ones:
- `aws-cdk-lib`
- `constructs`

No change for consumers that provide compatible packages
49 changes: 44 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
"@types/node": "20.11.5",
"@types/yargs": "^17.0.32",
"aws-cdk": "2.121.1",
"aws-cdk-lib": "2.121.1",
"constructs": "10.3.0",
"cz-conventional-changelog": "^3.3.0",
"eslint": "^8.56.0",
"eslint-plugin-custom-rules": "file:tools/eslint",
Expand All @@ -55,11 +57,9 @@
},
"dependencies": {
"@oclif/core": "2.15.0",
"aws-cdk-lib": "2.121.1",
"aws-sdk": "^2.1538.0",
"chalk": "^4.1.2",
"codemaker": "^1.94.0",
"constructs": "10.3.0",
"git-url-parse": "^14.0.0",
"js-yaml": "^4.1.0",
"lodash.camelcase": "^4.3.0",
Expand All @@ -78,4 +78,4 @@
"path": "./node_modules/cz-conventional-changelog"
}
}
}
}

0 comments on commit a08c35c

Please sign in to comment.