Skip to content

Commit

Permalink
Merge pull request #2528 from guardian/changeset-release/main
Browse files Browse the repository at this point in the history
🦋 Release package updates
  • Loading branch information
rtyley authored Dec 5, 2024
2 parents 19be12c + 40d2995 commit 5f483a0
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 22 deletions.
16 changes: 0 additions & 16 deletions .changeset/friendly-trainers-cry.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/soft-scissors-turn.md

This file was deleted.

21 changes: 21 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
# @guardian/cdk

## 61.0.0

### Major Changes

- d3259e7: Support multiple usages of `GuGithubActionsRole` in a single AWS account

This significantly changes the resources constructed by `GuGithubActionsRole`,
specifically, **the construct will no longer instantiate a `GitHubOidcProvider`**.
This is because you can only ever have one `GitHubOidcProvider` per provider
domain (ie `token.actions.githubusercontent.com`) - while we may want multiple
instances of `GuGithubActionsRole` in an AWS account, we can't have the
`GuGithubActionsRole` construct trying to make a new `GitHubOidcProvider` with
each instance.

Consequently, you will need to instantiate the `GitHubOidcProvider` elsewhere
as a singleton. At the Guardian, we do this with https://github.com/guardian/aws-account-setup.

### Minor Changes

- bf08a5e: Default to GP3 storage type for RDS

## 60.1.3

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@guardian/cdk",
"description": "Generic Guardian flavoured AWS CDK components",
"version": "60.1.3",
"version": "61.0.0",
"main": "lib/index.js",
"types": "lib/index.d.ts",
"files": [
Expand Down

0 comments on commit 5f483a0

Please sign in to comment.