Skip to content

Commit

Permalink
Merge pull request #2080 from guardian/aa/rm-elb
Browse files Browse the repository at this point in the history
feat(elb)!: Remove support for classic load balancers
  • Loading branch information
akash1810 authored Oct 31, 2023
2 parents 4ab9d35 + 2fd7d33 commit 5dea19a
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 336 deletions.
11 changes: 11 additions & 0 deletions .changeset/stupid-apes-poke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@guardian/cdk": major
---

Remove support for classic load balancers.

Use of application load balancers (ALBs) is considered best practice,
as ALBs are receiving [more capabilities](https://aws.amazon.com/elasticloadbalancing/features/) than elastic (classic) load balancers (ELBs).
GuCDK should be encoding best practice, so remove support for ELBs.

Please adopt application load balancers instead, or if necessary, use ELBs directly from AWS CDK.
199 changes: 0 additions & 199 deletions src/constructs/loadbalancing/elb.test.ts

This file was deleted.

136 changes: 0 additions & 136 deletions src/constructs/loadbalancing/elb.ts

This file was deleted.

1 change: 0 additions & 1 deletion src/constructs/loadbalancing/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
export * from "./alb";
export * from "./elb";

0 comments on commit 5dea19a

Please sign in to comment.