Merge pull request #2150 from guardian/aa/rm-stack-set

feat(stack-set)!: Remove support for Stack Sets

.changeset/curly-peas-rule.md

@@ -0,0 +1,10 @@
+---
+"@guardian/cdk": major
+---
+
+Removes supports for Stack Sets (added in #977) as it's no longer used,
+because of a lack of CD tooling support for deploying Stack Sets.
+
+Removing unused code means less code to maintain, and reduced complexity.
+
+Should Stack Sets be needed in future, https://github.com/cdklabs/cdk-stacksets offers an alternative approach to creating them in CDK.

src/constructs/core/stack.ts

@@ -1,6 +1,5 @@
-import type { CfnElement, StackProps } from "aws-cdk-lib";
-import { Annotations, App, Aspects, CfnParameter, LegacyStackSynthesizer, Stack, Tags } from "aws-cdk-lib";
-import { Template } from "aws-cdk-lib/assertions";
+import type { App, CfnElement, StackProps } from "aws-cdk-lib";
+import { Annotations, Aspects, CfnParameter, LegacyStackSynthesizer, Stack, Tags } from "aws-cdk-lib";
 import type { IConstruct } from "constructs";
 import gitUrlParse from "git-url-parse";
 import { AwsBackupTag } from "../../aspects/aws-backup";
@@ -268,19 +267,3 @@ export class GuStack extends Stack implements StackStageIdentity {
     Annotations.of(construct).addInfo(`Setting logical ID for ${id} to ${logicalId}. Reason: ${reason}`);
   }
 }
-
-/**
- * A GuStack but designed for Stack Set instances.
- *
- * In a stack set application, `GuStackForStackSetInstance` is used to represent the infrastructure to provision in target AWS accounts.
- */
-export class GuStackForStackSetInstance extends GuStack {
-  // eslint-disable-next-line custom-rules/valid-constructors -- GuStackForStackSet should have a unique `App`
-  constructor(id: string, props: GuStackProps) {
-    super(new App(), id, props);
-  }
-
-  get cfnJson(): string {
-    return JSON.stringify(Template.fromStack(this).toJSON(), null, 2);
-  }
-}