Notify Anghammard's admins on messaging failure #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When Anghammarad fails to send a message, we now notify the system's admins (DevX). The CTA for this warning notification is to review Anghammarad's logs for more information. Previously we would log information on failure but people wouldn't necessarily know to go and look for this information.
adamnfish
force-pushed
the
notify-admins-on-message-failure
branch
from
e364570 to
e4069f0
Compare
|
I think this would be better implemented on the actual Anghammarad service, rather than being specific to the Lambda function wrapper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
When Anghammarad fails to send a message, we now notify the system's admins (DevX). The CTA for this warning notification is to review Anghammarad's logs for more information. Previously we would log information on failure but people wouldn't necessarily know to go and look for this information.
How to test
We can send a deliberately mis-targeted message and check that the alert notification is received.