Ensure sbt is properly installed in GitHub actions #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamnfish
force-pushed
the
add-guardian-setup-scala-to-workflows
branch
from
28b70c0 to
0b2a7d9
Compare
adamnfish
changed the title
adamnfish
changed the title
jorgeazevedo
approved these changes
Dec 4, 2024
4 tasks
|
#740 is failing CI with "sbt not found". Merging this to resolve. |
This allows us to also setup sbt at the same time, and simplify the workflow configuration. We take the Java version out of the .tool-versions file, so this is also added with a (currently) up-to-date Java version.
akash1810
force-pushed
the
add-guardian-setup-scala-to-workflows
branch
from
0b2a7d9 to
1f2dff5
Compare
akash1810
approved these changes
Dec 17, 2024
bryophyta
added a commit
to guardian/newswires
that referenced
this pull request
Jan 6, 2025
…bt, following the removal of sbt from Github's base images. See [prior example](guardian/amiable#738). Also adds a `.tool-versions` file specifying the version of Java to use in the action, and removes the old `.java-version` file because afaict it was only being used by the `setup-java` action that's been removed above.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Using the Guardian-provided setup-scala workflow allows us to configure and install Java and sbt at the same time. It takes the Java version out of the .tool-versions file, so this file is also added with a (currently) up-to-date Java version.
How to test
We should see the workflows complete successfully now.
How can we measure success?
We'll avoid these workflows breaking when GitHub starts to roll-out the new base image from 5th Dec.
Have we considered potential risks?
We're specifying a needlessly specific Java version in the .tool-versions file, to appease
asdf. We will separately migrate to just the major version by adopting mise, but this is something to change globally when we are ready.