This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Deprecate actions-sbt-release
in favour of gha-scala-library-release-workflow
#1
Merged
rtyley
merged 1 commit into
main
from
deprecate-in-favour-of-gha-scala-library-release-workflow
Jan 9, 2024
Merged
Deprecate actions-sbt-release
in favour of gha-scala-library-release-workflow
#1
rtyley
merged 1 commit into
main
from
deprecate-in-favour-of-gha-scala-library-release-workflow
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
added a commit
to guardian/fezziwig
that referenced
this pull request
Jan 5, 2024
rtyley
added a commit
to guardian/fezziwig
that referenced
this pull request
Jan 5, 2024
rtyley
added a commit
to guardian/fezziwig
that referenced
this pull request
Jan 5, 2024
rtyley
added a commit
to guardian/fezziwig
that referenced
this pull request
Jan 5, 2024
rtyley
added a commit
to guardian/atom-maker
that referenced
this pull request
Jan 9, 2024
Here we're switching from using `actions-sbt-release` to `gha-scala-library-release-workflow` for publishing releases of this library - see also guardian/actions-sbt-release#1. A fair bit of sbt configuration is deleted or changed - see the docs on config changes for more information: https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md Once this PR is merged, we should also delete the old repository secrets: https://github.com/guardian/atom-maker/settings/secrets/actions
rtyley
added a commit
to guardian/atom-maker
that referenced
this pull request
Jan 9, 2024
Here we're switching from using `actions-sbt-release` to `gha-scala-library-release-workflow` for publishing releases of this library - see also guardian/actions-sbt-release#1. A fair bit of sbt configuration is deleted or changed - see the docs on config changes for more information: https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md Once this PR is merged, we should also delete the old repository secrets: https://github.com/guardian/atom-maker/settings/secrets/actions
rtyley
added a commit
to guardian/atom-maker
that referenced
this pull request
Jan 9, 2024
Here we're switching from using `actions-sbt-release` to `gha-scala-library-release-workflow` for publishing releases of this library - see also guardian/actions-sbt-release#1. A fair bit of sbt configuration is deleted or changed - see the docs on config changes for more information: https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md Once this PR is merged, we should also delete the old repository secrets: https://github.com/guardian/atom-maker/settings/secrets/actions
rtyley
force-pushed
the
deprecate-in-favour-of-gha-scala-library-release-workflow
branch
from
January 9, 2024 11:23
a72255b
to
5faa6b0
Compare
paulmr
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems very sensible to me. The need for this action is definitely obviated by the reusable workflow.
If we the action can still run from an archived repo then we could archive it straight away, but otherwise then yes I guess we do need to wait until the dependent repos have been migrated.
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a reusable workflow, rather than a GitHub Action,
gha-scala-library-release-workflow
is able to isolate release phases in GHA jobs, providing better release credential security. Now that guardian/gha-scala-library-release-workflow#19 means the workflow can do 'preview' style releases, I think it's able to take over most use cases ofactions-sbt-release
.Hope the wording here is ok - I think once guardian/fezziwig#45 & guardian/atom-maker#93 are merged we should be okay to archive this repo?