Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Deprecate actions-sbt-release in favour of gha-scala-library-release-workflow #1

Merged

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Jan 5, 2024

As a reusable workflow, rather than a GitHub Action, gha-scala-library-release-workflow is able to isolate release phases in GHA jobs, providing better release credential security. Now that guardian/gha-scala-library-release-workflow#19 means the workflow can do 'preview' style releases, I think it's able to take over most use cases of actions-sbt-release.

Hope the wording here is ok - I think once guardian/fezziwig#45 & guardian/atom-maker#93 are merged we should be okay to archive this repo?

rtyley added a commit to guardian/fezziwig that referenced this pull request Jan 5, 2024
rtyley added a commit to guardian/fezziwig that referenced this pull request Jan 5, 2024
rtyley added a commit to guardian/fezziwig that referenced this pull request Jan 5, 2024
rtyley added a commit to guardian/fezziwig that referenced this pull request Jan 5, 2024
rtyley added a commit to guardian/atom-maker that referenced this pull request Jan 9, 2024
Here we're switching from using `actions-sbt-release` to
`gha-scala-library-release-workflow` for publishing releases of this
library - see also guardian/actions-sbt-release#1.

A fair bit of sbt configuration is deleted or changed - see the docs on
config changes for more information:

https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md

Once this PR is merged, we should also delete the old repository secrets:

https://github.com/guardian/atom-maker/settings/secrets/actions
rtyley added a commit to guardian/atom-maker that referenced this pull request Jan 9, 2024
Here we're switching from using `actions-sbt-release` to
`gha-scala-library-release-workflow` for publishing releases of this
library - see also guardian/actions-sbt-release#1.

A fair bit of sbt configuration is deleted or changed - see the docs on
config changes for more information:

https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md

Once this PR is merged, we should also delete the old repository secrets:

https://github.com/guardian/atom-maker/settings/secrets/actions
rtyley added a commit to guardian/atom-maker that referenced this pull request Jan 9, 2024
Here we're switching from using `actions-sbt-release` to
`gha-scala-library-release-workflow` for publishing releases of this
library - see also guardian/actions-sbt-release#1.

A fair bit of sbt configuration is deleted or changed - see the docs on
config changes for more information:

https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md

Once this PR is merged, we should also delete the old repository secrets:

https://github.com/guardian/atom-maker/settings/secrets/actions
@rtyley rtyley force-pushed the deprecate-in-favour-of-gha-scala-library-release-workflow branch from a72255b to 5faa6b0 Compare January 9, 2024 11:23
@rtyley rtyley marked this pull request as ready for review January 9, 2024 11:24
@rtyley rtyley requested a review from paulmr January 9, 2024 11:24
Copy link
Member

@paulmr paulmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very sensible to me. The need for this action is definitely obviated by the reusable workflow.

If we the action can still run from an archived repo then we could archive it straight away, but otherwise then yes I guess we do need to wait until the dependent repos have been migrated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants