NotifySend: simpler notifications via libnotify without FFI #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Thank for this, looks good! I'll definitely want to merge this on Monday when I'm back from my holidays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to get the libnotify notifier working in JRuby because of a problem related to shared libraries and the fact that the gem uses FFI.
Instead of going down the shared library rabbit hole, I created a simpler notifier, "NotifySend", that does not use FFI but still leverages libnotify. Instead of FFI, it shells out to a program that comes with libnotify-bin, notify-send.
I think both Libnotify and NotifySend notifiers can coexist until me or someone else figures out what the problem is.
Thanks for your work on Guard, and in advance for considering my pull request.
Alan