Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: "uninitialized constant MiniTest::Unit::Guard::MinitestNotifier (NameError)" in 1.9.x #25

Merged
merged 1 commit into from
Feb 21, 2012

Conversation

grimen
Copy link
Contributor

@grimen grimen commented Dec 9, 2011

Since updating minitest and guard-minitest Guard raised error on every run.

@ream88
Copy link

ream88 commented Dec 12, 2011

+1

@snuggs
Copy link

snuggs commented Dec 21, 2011

PLEASE can someone update this? I'm having this error currently as we speak.

@somebox
Copy link

somebox commented Dec 27, 2011

+1

@ivanjovanovic
Copy link

+2

@aspiers
Copy link

aspiers commented Jan 5, 2012

Me too

@dcunited001
Copy link

I am as well. running 1.9.2-head, should I be running 1.9.3?

i looked into the code and 'guard/minitest' loads 'guard', which loads 'guard/notify'. i think the problem is when it loads the minitest/notifier file, its under the Minitest namespace, so it loads the class "MiniTest::Unit::Guard::MinitestNotifier", instead of Guard::MinitestNotifier. When i set a binding.pry on one of my tests, the Guard::MinitestNotifier class exists

I think this might have something to do with the way i'm requiring files/modules in my spec_helper. This is what i'm using to start up guard:
RUBYOPT=-rminitest/pride bundle exec guard start

@dcunited001
Copy link

nevermind, just saw your commit hah

@metaskills
Copy link

I am using guard-minitest with a 2.3.14 app on 1.8.7 and hit this error too. Would love to see a gem release so I do not have to monkey patch.

@aspiers
Copy link

aspiers commented Jan 9, 2012

I created my own fork from the patched fork, merged some other fixes in, and then changed my Gemfile:

gem 'guard-minitest', :git => 'git://github.com/aspiers/guard-minitest.git'

This is cleaner and more manageable than manually editing code, but I agree the patch should be pulled. Having said that, I gave up on guard-minitest altogether because there were too many other issues. I get the impression it's not really being maintained any more.

@snuggs
Copy link

snuggs commented Jan 9, 2012

Well there's definitely not an issue of contributors wanting to maintain. I being one of them myself.

@aspiers
Copy link

aspiers commented Jan 9, 2012

Luckily github makes that possible even without the approval of the original maintainer. Just make sure that your fork contains merges of all the good patches from everyone else's (if you look in the git network you will see TONS of unmerged forks) and then update the issues where appropriate to say that your fork has a fix. Then people will start using and writing patches against yours instead of the "official" one :) After all, the maintainer's job is pretty much just merging, and in a decentralized system anyone can do that :)

@metaskills
Copy link

@aspiers Have you tried contacting the maintainer of this repo and ask if you can get access to both this repo as a collaborator? Github makes that really easy. Also, rubygems.org makes it easy to add another owner to the gem space, see here. http://guides.rubygems.org/command-reference/#gem_owner

When I took over active development for the less-rails gem, the old author was more than willing to let me start working in both of the official spaces. I can even help on this project too since I have been pushing MiniTest for some time now. Lemme know.

BTW, I forked your repo on my work account and published a 'guard-minitest-decisiv' gem as a quick patch to a bundler issues. Seems 1.1rc is broken and will always pull in a :git based even if that gem is in a group that is supposed to be ignored using the --without option.

@snuggs
Copy link

snuggs commented Jan 20, 2012

Already contacted multiple of the repo owners. No dice.

@heathd
Copy link

heathd commented Jan 28, 2012

+1

I just did exactly the same fix and then saw others have been here before me!

@yannlugrin
Copy link
Member

I planned time early next week for the maintenance of this gem

@ghost ghost assigned yannlugrin Feb 2, 2012
@zhon
Copy link

zhon commented Feb 4, 2012

+1

1 similar comment
@bltavares
Copy link

+1

yannlugrin added a commit that referenced this pull request Feb 21, 2012
Fixes: "uninitialized constant MiniTest::Unit::Guard::MinitestNotifier (NameError)" in 1.9.x
@yannlugrin yannlugrin merged commit 06eb6f2 into guard:master Feb 21, 2012
@yannlugrin
Copy link
Member

release 0.5.0.rc1 include this pull request

@snuggs
Copy link

snuggs commented Feb 21, 2012

The heavens have spoken! TY @yannlugrin

@metaskills
Copy link

"officially" awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.