-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce scorecard workflow permissions scope #2326
Reduce scorecard workflow permissions scope #2326
Conversation
4f86ef0
to
c7f93be
Compare
I did try with the id-token: write permission set but it seems that the Scorecard API has some checks to ensure the integrity of the data, including default branch check: https://github.com/robert-cronin/guac/actions/runs/12076752606/job/33678574053 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't declare write permissions at the workflow level as a matter of practice. Write permissions should be granted on a per-job basis as needed. The practical effect is the same here, since there's only one job, but the tooling will still complain :-)
c7f93be
to
f7fe0a3
Compare
Oh, I missed the existing id-token permission set on the job level! Thank you for catching that! I'll take out the permission I added to the workflow level |
Signed-off-by: robert-cronin <[email protected]>
f7fe0a3
to
0c3b288
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of the PR
Fixes #2275
PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run