-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included REST Spec Changes #2217
Open
nathannaveen
wants to merge
2
commits into
guacsec:main
Choose a base branch
from
nathannaveen:nathan/updateApiSpec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathannaveen
force-pushed
the
nathan/updateApiSpec
branch
from
October 25, 2024 15:43
0c02fd0
to
0577c13
Compare
mdeicas
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great change, thanks @nathannaveen! Thank you as well for splitting the original PR up and adding documentation to the API spec. I added comments but overall it looks good.
* Second Part of guacsec#2089 * All the OpenAPI Spec changes have been included * The `/query/dependencies` is no longer going to be used, instead, the `/v0/package/{purl}/dependencies` and `/v0/artifact/{digest}/dependencies` will be replacing it. * The code in retrieveDependencies.go has been updated to work for the new endpoints. Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
nathannaveen
force-pushed
the
nathan/updateApiSpec
branch
from
December 4, 2024 19:36
1f419a5
to
a1a91c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
/query/dependencies
is no longer going to be used, instead, the/v0/package/{purl}/dependencies
and/v0/artifact/{digest}/dependencies
will be replacing it.PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run