gio: Don't wrongly cast DataInputStream byte arrays to a const pointer #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're transfer full and need to be freed, which wouldn't be possible for a const pointer. Fixes gtk-rs#1237
…pies The returned values are already transfer full so copying them to a `Vec` is unnecessary.
sdroege
added
the
needs-backport
GuillaumeGomez
approved these changes
Dec 3, 2023
sdroege
removed
the
needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1237
Also don't use
Vec<u8>in a few places to avoid needless copies. Only the first commit should be backported to 0.18.