-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement basic virtual methods support #1463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
force-pushed
the
bilelmoussaoui/vfunc-docs
branch
from
April 30, 2023 01:08
8d60ed6
to
ab08e60
Compare
bilelmoussaoui
commented
Apr 30, 2023
bilelmoussaoui
force-pushed
the
bilelmoussaoui/vfunc-docs
branch
from
April 30, 2023 22:24
ab08e60
to
57dea4f
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/vfunc-docs
branch
2 times, most recently
from
April 30, 2023 22:49
4f7fe4c
to
5197e38
Compare
This should be ready for a proper review now. Can't do much about testing with gtk-rs-core as it is still blocked by the gir rustdoc feature changes. |
Tested with gstreamer, works great. |
sdroege
reviewed
May 3, 2023
sdroege
reviewed
May 3, 2023
sdroege
reviewed
May 3, 2023
sdroege
reviewed
May 3, 2023
Looks good to me apart from the naming things |
bilelmoussaoui
force-pushed
the
bilelmoussaoui/vfunc-docs
branch
from
May 3, 2023 16:53
5197e38
to
a111bb9
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/vfunc-docs
branch
from
May 3, 2023 16:54
a111bb9
to
9c0e96a
Compare
let us land this then :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention behind this PR is not to add code generation for subclassing code but it does a good step forward.
What the PR does currently:
[object.virtual_method]
Before
After
TODO:
Parts of #1319