Add check for missing license header #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Dec 14, 2020
src/license.rs
Outdated
| let header: Vec<String> = f.lines().take(3).map(|x| x.unwrap()).collect(); | ||
| Ok(header.len() == 3 && | ||
| header[0].starts_with("// Copyright ") && | ||
| header[0].ends_with(", The Gtk-rs Project Developers.") && |
There was a problem hiding this comment.
That wouldn't allow me to run it on gstreamer-rs, and would be a bit strict anyway.
Also note that "The Gtk-rs Project Developers" as a copyright declaration is rather useless as that's not a legal entity. That's as useful as writing "Santa Clause" there :)
See also gtk-rs/gtk3-rs#60 . If we fix this now let's do it properly instead of adding more useless information everywhere.
GuillaumeGomez
force-pushed
the
missing-license
branch
from
2b29359 to
6ca2471
Compare
sdroege
reviewed
Dec 14, 2020
GuillaumeGomez
force-pushed
the
missing-license
branch
from
6ca2471 to
69266a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.