Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Layer Revamped #147

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Network Layer Revamped #147

wants to merge 30 commits into from

Conversation

azooz2003-bit
Copy link
Contributor

#133

  • Added type safety since query params are handled per APIRequest conforming struct.
  • Models can be stored based on different properties, not just a parentId.
  • Overall cleaner codebase.
  • CanvasRequest is now a namespace struct with methods returning some api request.

@azooz2003-bit
fixed: enrollments was set off main thread
3f8fc00
@azooz2003-bit
new gradesVM
2cff85c
@azooz2003-bit
make sync discardable
50939b4
@azooz2003-bit
move grades logic to different VM
ed93daa
@azooz2003-bit
announcement and course sets moved to main
1ff1aad
@azooz2003-bit
wrong query made
4d6f2ab
@azooz2003-bit
rename getPeople -> getEnrollments to resolve ambiguities
c01452f
@azooz2003-bit
quiz schema half done
436a23e
@azooz2003-bit
quiz model complete
5a89e3b
@azooz2003-bit
added getQuizzes to service layer
689aa1f
@azooz2003-bit
add quiz to repository
5beecbc
@azooz2003-bit
optionalized some properties, quizzes working
b83a47b
@azooz2003-bit
fixed array storage failure
75deec6
@azooz2003-bit
created temporary list view
e6c258f
@azooz2003-bit
use all_quizzes instead of quizzes for request
e5b909c
@azooz2003-bit
title as fallback for quizzes sort
a1f0952
@azooz2003-bit
remove print
4654551
@azooz2003-bit
attempt 1 to change parent
46170df
@azooz2003-bit
protocol made
1e92ef6
@azooz2003-bit
handle nil values
7f0b7a1
@azooz2003-bit
all api requests recreated
6b4827d
@azooz2003-bit
fix quiz predicate compile error, hide enrollment predicate for now
0b72b64
@azooz2003-bit
predicates complete
53e3167
@azooz2003-bit
inits for all reqs
b22518f
@azooz2003-bit
revamped network layer complete! more type safe + models can accomoda…
d35eb29 
…te different parent properties
@rahulon12 rahulon12 linked an issue Dec 22, 2024 that may be closed by this pull request
[Improvement]: Revamped Network Layer #133
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulon12 rahulon12 Awaiting requested review from rahulon12

@iWatger iWatger Awaiting requested review from iWatger

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: Revamped Network Layer
1 participant
@azooz2003-bit