Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #623

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[email protected] #623

wants to merge 9 commits into from

Conversation

fibinali
Copy link

@fibinali fibinali commented Aug 7, 2024

Pull Request: Evaluation Criteria for Stage 3

Introduction

This pull request proposes a new set of evaluation criteria for Stage 3, focusing on advanced aspects of software development. These criteria are designed to assess and foster innovation, community engagement, effective feedback reception, collaboration, domain-specific knowledge, and system design skills.

Evaluation Criteria

Please review the following proposed criteria and check each box to indicate your review and agreement:

## Checklist:
Before you submit this pull request, please ensure you have completed the following items.

### Attitude and Values
- [ ] Feedback Reception: Openness to receiving feedback and making necessary improvements.
- [ ] Innovation: Attitude of thinking outside the box, coming up with novel solutions or approaches to problems.

### Abilities and Skills
- [ ] Collaboration: Skill in working within a team, understanding team dynamics, and contributing effectively.

### Knowledge and Information
- [ ] Domain-Specific Knowledge: Depending on the challenge, knowledge in areas like AI/ML,Becken, blockchain, game development, etc.
- [ ] System Design: Understanding of how to design scalable and efficient systems, including databases, servers, and client interactions.

### Other Criteria
- [ ] Has open source contributions

### Do you vouch for the top 100 coders?
- [ ] I vouch. You belong to the lead of Top 100 Coders 2023
- [ ] Good Job, All the best for the Top 100 Coders 2024

Code Evaluation Criteria


### Decisions - Pre Coding
- [ ] Did they have a pre-planning involved, with discussions about the complexities involved and how to solve?
- [ ] Can they reason their choice for selecting the tech stack used?

### Quality and Organization of Code
- [ ] Is the code clean, readable, well-organized and maintainable?
- [ ] Does the variable and function names make sense?
- [ ] Does the code adhere to best practices and standards? (structure, formatting, etc.)
- [ ] Are development best practices such as branching, merging, and pull requests well-utilized?
- [ ] Does the commit messages make sense?

### Authentication & Sanitization
- [ ] Does the project have a viable and secure authentication system in place?
- [ ] Are request parameters from the user sanitized before processing?

### Error Handling
- [ ] Are the errors rescued and handled well?
- [ ] Do they have an error monitoring in place?
- [ ] For the user, are the errors conveyed in a senseful manner?

### Working as a team
- [ ] Do the pull requests have apt title and description? Can the reviewer / team mate draw enough context from the pull request description?
- [ ] Are the pull requests slim? i.e, not bloated, no unrelated changes in the same PR? Is the PR easy to review?
- [ ] Did they have a good mode of communication? How often were the communication between the team?
- [ ] Did they have documentation / scratch pads / brainstorming sessions with the team for features while building?

### Database
- [ ] Does the project have a DB schema?
- [ ] Can they reason why they chose this database?
- [ ] Are adequate database validations in place? (Uniqueness or presence of emails for users etc.)
- [ ] If the database is hosted, how is the connection to the database established? Is it from inside a secure network?

### Scalability, Performance and Security Considerations
- [ ] Can the solution scale effectively?
- [ ] Is the solution well-prepared for external API related issues (timeouts, rate limiting, errors)?
- [ ] Does the project adequately address security and data management practices, particularly in relation to data handling and storage?
- [ ] How are the tokens managed? Are any tokens exposed on client side or being committed into code?

### Overall Technical Excellence
- [ ] Overall, does the technical aspect of the project and the coder stand out?

### Additional Feedback for Developers
> Please provide any additional feedback or observations

### Do you vouch for the top 100 coders?
- [ ] I vouch. You belong to the lead of Top 100 Coders 2023
- [ ] Good Job, All the best for the Top 100 Coders 2024

Purpose

The purpose of these criteria is to provide a comprehensive and structured approach to evaluating advanced skills and contributions in software development, ensuring continuous improvement and excellence.

How to Use

These criteria can be used for performance reviews, peer feedback, and self-assessment in advanced stages of software development roles.


Please review the proposed evaluation criteria for Stage 3 and check the corresponding boxes to indicate your review status, feedback, or approval. Your input is invaluable to ensure the criteria are robust and effective.

@vishakh-abhayan vishakh-abhayan added the Changes requested This doesn't seem right label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants