Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invitation modal #287

Merged
merged 28 commits into from
Mar 23, 2024
Merged

Invitation modal #287

merged 28 commits into from
Mar 23, 2024

Conversation

joannacheng21
Copy link
Contributor

@joannacheng21 joannacheng21 commented Feb 23, 2024

Summary

Resolves #281

Checklist

  • Modify InvitationModalContent in ``src/components/InvitationModal` to now also use all of the version names from the ScheduleContext and create the input component for selecting which versions to share.
  • Modify the request made to /createFriendInvitation to now use a list of versions instead of a single version
  • When the modal opens, pre-select the current version the user is on. Generate a new link and attach to copy link button, upon clicking which the link is copied to the user's clipboard.
  • Everytime a user changes the selected versions, generate a new link and attach to button.
  • Modify the logic for checking if the invitee has already accepted an invite from the sender.
  • The ScheduleContext currently contains the invites sent only for the version the user is currently on. The context needs to be updated to now contain invites from all versions (can probably be done using termScheduleData passed to the context provider).
  • Update the middle section of the modal accordingly and show invites from all version instead of just current. Make this component scrollable in case it becomes longer than a specified height.
  • Modify logic for removing friends now that there are multiple schedule versions
  • Create link expiration dropdown and connect selection to createLink function

How to Test

Change cloud function base url to test

Notes:

  1. When I try to send email invite, I'm getting the error Error: connect ECONNREFUSED 127.0.0.1:465 from nodemailer, I don't think this is my code's problem? or maybe it is
  2. Had to make couple changes to firebase functions, should I make pr to firebase repo?
  3. Question: "Modify the logic for checking if the invitee has already accepted an invite from the sender." what are we doing if the invitee has accepted invites for some but not all selected schedules?
  4. How are we setting validFor field for links that never expire? put it as 1000 days for now

Copy link

github-actions bot commented Feb 24, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://gt-scheduler.github.io/website/pr-preview/pr-287/
on branch gh-pages at 2024-03-23 07:37 UTC

@joannacheng21 joannacheng21 marked this pull request as ready for review February 24, 2024 23:02
@winniezhangg
Copy link

Hi Joanna!
A couple of comments on the design for the invite modal
Reference to what the Figma Design looks like:
Screen Shot 2024-02-25 at 2 43 33 PM

  1. Apologies if this was not specified enough on the Figma and ticket, but the scrollable div should be:
Screen Shot 2024-02-25 at 6 49 26 PM instead of how it is right now with each section being scrollable

this is how it should look:
Screen Shot 2024-02-25 at 6 50 24 PM

  1. Please left align the schedule checkboxes with the left side of the email input
Screen Shot 2024-02-25 at 6 51 12 PM
  1. Same with the copy link button and link expires button, align them with the inner edge:
Screen Shot 2024-02-25 at 6 53 01 PM

Good work so far! Let me know if I can help clarify anything! Ping me if you have updates and need feedback!

@yatharth-b yatharth-b closed this Mar 5, 2024
@yatharth-b yatharth-b reopened this Mar 5, 2024
Copy link
Contributor

@yatharth-b yatharth-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, LGTM! I will fix some merge conflicts with bog-changes-s23-merged and change the delete function when requierd since we have updated that endpoint.

@yatharth-b yatharth-b merged commit a1f180b into bog-changes-s23-merged Mar 23, 2024
3 checks passed
@yatharth-b yatharth-b deleted the invitation-modal branch March 23, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants