Fixes PR Preview Link Auto Redirecting #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, GitHub Pages does not allow for dynamic links such as
https://www.gt-scheduler.org/invite/:id. Moreso, if you go to a PR preview, such ashttps://www.gt-scheduler.org/pr-preview/pr-253/, it auto redirects the site tohttps://www.gt-scheduler.org.This PR converts the router to a Hash Router which is compatible with GitHub Pages. This PR also updates the create friend Firebase function such that it accepts a backlink for the email invite (related PR: gt-scheduler/firebase-conf#8).
Note: Hash Routers are deprecated, and GitHub Pages deployments are not ideal for SPAs. I would recommend switching our tech stack to Next.js and deployments to Netlify.