Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gss_set_cred_option #76

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Implement gss_set_cred_option #76

merged 3 commits into from
Jun 23, 2022

Conversation

simo5
Copy link
Collaborator

@simo5 simo5 commented Jun 23, 2022

Add also a way to use this function to set NEGOTIATE flags for both ISC and ASC.

Fixes #75

@simo5
Copy link
Collaborator Author

simo5 commented Jun 23, 2022

@filipnavara any chance you could test if this gssntlmssp patch fixes the .NET problem you reported to krb5?

@filipnavara
Copy link

Sure, will do.

@filipnavara
Copy link

I tried it on Ubuntu 20.04 under WSL and unfortunately it still seems to go through the default gssspi_set_cred_option implementation and ignores gssntlm_set_cred_option. I am not sure how the mechanism glue is working in detail and what to check. lldb shows that the correct build of gssntlmssp.so was used and I can put breakpoints inside the new methods.

simo5 added 3 commits June 23, 2022 07:24
This requires to explicitly acquire credentials before calling into
the ISC or ASC functions. Then setting the new default flags on the
credntial. It is not elegant to mix credentials and context flags,
but it is the only way to do it in GSSAPI currently, and there is
precedent in other mechanisms like KRB5.

Signed-off-by: Simo Sorce <[email protected]>
@simo5
Copy link
Collaborator Author

simo5 commented Jun 23, 2022

@filipnavara thanks a ton! You rock!

@simo5 simo5 merged commit 8149435 into gssapi:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement gss_set_cred_option()
2 participants