Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to add a special key while using quicknote causes a crash #1700

Closed
3 tasks done
jyjsunny opened this issue May 11, 2022 · 2 comments
Closed
3 tasks done

Trying to add a special key while using quicknote causes a crash #1700

jyjsunny opened this issue May 11, 2022 · 2 comments

Comments

@jyjsunny
Copy link

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The issue is not already reported at Issues or discussions. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.

Description

Trying to add a special key while using quicknote causes a crash

There is a video:

Trying.to.add.a.special.key.while.using.quicknote.causes.a.crash.mov

Steps to reproduce

  1. click to use the "quitenote"
  2. input some words
  3. click to add a special key
  4. click to "ok"
  5. crash and exit

Information

Android version: Android 8
Device: Google Pixel 4
App Version: 2.8.6

Source

Google Play

Format / File type

No

Additional info / Log

-
@harshad1
Copy link
Collaborator

I can reproduce this. Will investigate and fix.

@gsantner
Copy link
Owner

gsantner commented May 21, 2022

Duplicate reason to #1699 . What did you expect to happen when clicking OK? You didn't select something!

See my comment in 1699.

@gsantner gsantner self-assigned this May 21, 2022
gsantner added a commit that referenced this issue May 21, 2022
…ion, by @gsantner closes #1699, closes #1700

* Hide OK button at multiple dialogs
* Therefore fix crash by pressing OK button with undefined action
* Fix crash when pressing keyboard next in the same case where OK button is undefined
@gsantner gsantner added this to the Markor v2.10 milestone Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants