Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip packer init for non-HCL templates #975

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Skip packer init for non-HCL templates #975

merged 1 commit into from
Aug 16, 2021

Conversation

bwhaley
Copy link
Contributor

@bwhaley bwhaley commented Aug 16, 2021

Packer logs an error if packer init is attempted on a JSON template, so terratest should skip init if the template is JSON.

yorinasub17
yorinasub17 approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bwhaley
Copy link
Contributor Author

bwhaley commented Aug 16, 2021

Thx! Merging + releasing now.

@bwhaley bwhaley merged commit 3984e1d into master Aug 16, 2021
@bwhaley bwhaley deleted the check-for-packer-json branch August 16, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorinasub17 yorinasub17 yorinasub17 approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwhaley @yorinasub17