Support multiarch docker image builds #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
commented
Aug 6, 2021
| @@ -1,9 +1,12 @@ | |||
| package aws | |||
There was a problem hiding this comment.
This is a bonus test stability fix I rolled in so I can get a green build.
|
Thanks for review! Going to merge this in now. |
This was referenced Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just got the M1 Macbook, and almost everything works except for Terratest tests that require pushing an image to AWS to run on amd64 machines (e.g., ECS Deploy Runner).
This PR updates the build functions in terratest to support multiarchitecture builds using the buildx command that docker desktop supports.