-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for packer v1.7.0 #964
Conversation
This reverts commit b4550ab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few nits, but overall LGTM! You can choose to address the nits in this PR, or in a follow up PR.
Feel free to merge as is (assuming the build passes!)
Thanks for the review. I've incorporated the feedback. Relevant tests are passing, but I notice that
Is this a known testing error? |
I don't think this is a known error given that it passed recently. I think this might be a new error caused by overlapping git commit SHA prefixes that caused it to require another character to differentiate that one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates LGTM!
Thanks! Relevant tests are passing. Will submit a new PR to fix the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ben, it looks like a few of the Packer templates were deleted... But these were used on the Terratest home page as examples: https://terratest.gruntwork.io/#test-with-terratest. If you click "Packer" and the "build.json" tab, you get an error. Could you update those examples to use the HCL files instead?
Doh, I thought I'd found all the references. Opened #966 to fix. |
Fixes #948.
Adds support for running
packer init
in Packer version >= v1.7.0. A few comments about this change:DisableTemporaryPluginPath
to disable it if desired.All comments & feedback welcome!