Add helper for extracting plan struct without logging and without specifying a plan file #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cifying a plan file
|
Thanks for review! Going to merge this in now. |
This was referenced Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm finding myself rewriting versions of this function more often than not, to the point that it probably makes sense to live in terratest.
The point of this function is:
Avoid logging the planfile json to console. This is a really big log message that is not human readable, and is not very useful for debugging (there are other, easier ways to debug the plan file, such as by introspecting the struct using delve).
Avoid having to specify where to store the plan file. After some usage, I realized that I never need the plan file on disk after I get the struct out.