Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test terraform 1.0.x #956

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Test terraform 1.0.x #956

merged 1 commit into from
Jul 22, 2021

Conversation

yorinasub17
Copy link
Contributor

This PR bumps the tested terraform version to 1.0.x

@yorinasub17 yorinasub17 requested a review from brikis98 as a code owner July 22, 2021 13:36
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming tests pass of course!

@yorinasub17
Copy link
Contributor Author

Build failed, but between the last two runs, all tests passed, so going to go ahead and merge this in. Thanks for review!

For reference, here is the build link and failed tests:

https://app.circleci.com/pipelines/github/gruntwork-io/terratest/692/workflows/152086c1-a17e-4c0d-9924-4dfb7ceb3939 : TestDoInBackgroundUntilStopped failed
https://app.circleci.com/pipelines/github/gruntwork-io/terratest/692/workflows/c963f897-0478-4703-95e6-ee9f711c087b : TestTerraformRedeployExample failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants