Implement Terragrunt validate #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackproser
changed the title
zackproser
commented
Aug 3, 2021
| @@ -69,6 +82,28 @@ func NewValidationOptions(rootDir string, includeDirs, excludeDirs []string) (*V | |||
| return vo, nil | |||
| } | |||
|
|
|||
| // NewValidationOptions returns a ValidationOptions struct, with override-able sane defaults, configured to find | |||
| // and process all directories containing .tf files | |||
| func NewValidationOptions(rootDir string, includeDirs, excludeDirs []string) (*ValidationOptions, error) { | |||
There was a problem hiding this comment.
By splitting NewValidationOptions into two separate functions, one that configures ValidationOptions with a FileType of TF for Terraform, and one that configures ValidationOptions with a FileType of TG for Terragrunt, we can a backward incompatible release for the tests already calling the NewValidationOptions function.
yorinasub17
reviewed
Aug 4, 2021
There was a problem hiding this comment.
Looks like good progress. I have a couple high level thoughts:
- We want to run both
terragrunt validate-inputsANDterragrunt validate. The latter is important to run to ensuregenerateblocks output valid terraform configuration. - Can you do a speed test to compare if it is faster to run
validatein this way, or if you runrun-all validatelike we are doing in the service catalog repo smoke test? I have a sneaking suspicion thatrun-all validatemight be significantly faster, but I could be wrong.
zackproser
force-pushed
the
terragrunt-validate-all
branch
from
e8bfc84 to
be9d3ef
Compare
Thanks for the reviews! Going to merge this in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
validate-inputscommand via PR