Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add methods to handle jobs in terratest #940

Merged
merged 1 commit into from
Jul 16, 2021
Merged

feat: add methods to handle jobs in terratest #940

merged 1 commit into from
Jul 16, 2021

Conversation

cyril-corbon
Copy link
Contributor

@cyril-corbon cyril-corbon commented Jun 26, 2021 •
edited
Loading

This PR is for adding Job to Terratest.

implement :

  • ListJob
  • GetJob
  • WaitUntilJobSucceed

add job_test too

@cyril-corbon cyril-corbon force-pushed the feat/add-job-methods branch 2 times, most recently from 41f7dd2 to ccaca8b Compare June 26, 2021 14:26
aslafy-z
aslafy-z reviewed Jun 28, 2021
View reviewed changes
modules/k8s/errors.go Outdated Show resolved Hide resolved
aslafy-z
aslafy-z reviewed Jun 28, 2021
View reviewed changes
modules/k8s/job.go Outdated Show resolved Hide resolved
@cyril-corbon cyril-corbon force-pushed the feat/add-job-methods branch from ccaca8b to 4c177c8 Compare July 3, 2021 11:21
yorinasub17
yorinasub17 reviewed Jul 7, 2021
View reviewed changes
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This mostly LGTM, but I had one question about IsJobSucceeded

modules/k8s/job.go Outdated Show resolved Hide resolved
modules/k8s/job.go Outdated Show resolved Hide resolved
modules/k8s/job.go Outdated Show resolved Hide resolved
@cyril-corbon cyril-corbon force-pushed the feat/add-job-methods branch from 4c177c8 to a6306fe Compare July 16, 2021 06:33
@cyril-corbon cyril-corbon force-pushed the feat/add-job-methods branch from a6306fe to 09c7e1c Compare July 16, 2021 06:49
@cyril-corbon cyril-corbon requested a review from yorinasub17 July 16, 2021 06:52
yorinasub17
yorinasub17 approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM! I'll kick off a regression build and if that passes, we can merge this in!

@yorinasub17
Copy link
Contributor

The overall build failed, but the relevant kubernetes tests passed, so we can merge this in. Thanks for your contribution!

@yorinasub17 yorinasub17 merged commit 46fba20 into gruntwork-io:master Jul 16, 2021
This was referenced Jul 16, 2021
Merged
Merged
Closed
Merged
@cyril-corbon cyril-corbon deleted the feat/add-job-methods branch July 22, 2021 06:55
@renovate renovate bot mentioned this pull request Jul 22, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslafy-z aslafy-z aslafy-z left review comments

@yorinasub17 yorinasub17 yorinasub17 approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyril-corbon @yorinasub17 @aslafy-z