Copy validated Terraform to /tmp to avoid conflict #935
Conversation
modules/terraform/validate.go
Outdated
| tfOpts := &Options{TerraformDir: dir} | ||
|
|
||
| //Copy the module to a tmp directory to avoid conflicts with tests that don't copy to /tmp | ||
| testFolder, err := files.CopyTerraformFolderToTemp(opts.RootDir, filepath.Base(dir)) |
There was a problem hiding this comment.
Note that, due to an import cycle error, I had to use the files package's CopyTerraformFolderToTemp method. test_structure imports the terraform package.
There was a problem hiding this comment.
Is this logic correct? I think this is wrong for cases where there is a subdir (e.g., modules/agents/cloudwatch-agent).
I think you need to use filepath.Rel here.
There was a problem hiding this comment.
Thanks! Revised as discussed.
| // Excludes any folders specified in the ValidationOptions.ExcludeDirs. IncludeDirs will take precedence over ExcludeDirs | ||
| // Use the NewValidationOptions method to pass relative paths for either of these options to have the full paths built | ||
| // Note that go_test is an alias to Golang's native testing package created to avoid naming conflicts with Terratest's | ||
| // own testing package. We are using the native testing.T here because Terratest's testing.T struct does not implement Run |
There was a problem hiding this comment.
NIT: Mention that the this is here instead of terraform module to avoid import cycling.
| @@ -1,4 +1,4 @@ | |||
| package terraform | |||
| package test_structure | |||
There was a problem hiding this comment.
NIT: Mention in the function docs that this is here instead of terraform module to avoid import cycling.
There was a problem hiding this comment.
NIT: This file should probably still be called validate_struct.go, given the contents.
|
Thanks for the review! Going to merge this in now but will address your nits in a follow-up PR. |
/tmpfirst, which can lead to conflicts whenValidateAllTerraformModulesis called/tmpFindTerraformModulePathsInRootEto return.terraformhidden directories, leading to duplicate work and possible false positives.