Fix build #898
Merged
Fix build #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for review! Merging this in now. |
This was referenced May 21, 2021
robcamer
pushed a commit
to aztfmod/terratest
that referenced
this pull request
Jun 14, 2021
* Bump to go 1.16 * Limit build parallelism * Add go111module setting * Use go 1.16.3 * Use working directory in go src dir * Make sure all jobs have the same working_directory * Call go mod tidy * bump hardcoded go version in test fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, terratest build process stopped working (See https://app.circleci.com/pipelines/github/gruntwork-io/terratest/553/workflows/59862dba-539e-4d0a-8f9b-f0af33b7b4db for example). I still don't understand why this is happening given that I can't repro locally both in my Mac and Linux boxes. However, what appears to happen is that
gocompletely ignores thego.modandgo.sumfiles located at the root in the circleci environment.So I bumped golang to the latest version. This appears to have worked, but introduced a different problem where it thinks the
go.modfile is out of date, even though it is up to date in my local env (when I rungo mod tidylocally, nothing changes!).In any case, the build appears to have been fixed when I added a call to
go mod tidyprior tobuild-go-binaries.As a bonus, this adds
darwin/arm64binaries forterratest_log_parserandpick-instance-typebins.