feat: add AWS SSO support #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support AWS SSO we need to Bump the AWS SDK which is providing support recently. Also we need to adjust our creation of sessins to include the `SharedConfigState` field. See https://aws.amazon.com/blogs/developer/aws-sso-support-in-the-aws-sdk-for-go/ for more information.
yorinasub17
previously approved these changes
Apr 29, 2021
yorinasub17
reviewed
Apr 29, 2021
|
@yorinasub17 thanks for the hint. It is now fixed :) |
|
Sorry for the delay in replying here! This patch worked, but it broke our binary build pipeline because the updated aws-sdk-go version requires more resources to compile. Can you apply this commit here? 1919b72 With that change, we should be able to merge this in! |
|
Ok, sorry for the delay but I know cherry-picked the mentioned commit. |
|
Would be awesome to have this, it is blocking us now! |
|
Apologies for the delay. Update LGTM! I am kicking off the build now and if it passes, we can merge this in. |
yorinasub17
approved these changes
May 28, 2021
infraredgirl
approved these changes
May 28, 2021
|
Thanks @infraredgirl ! Merging now. |
This was referenced May 28, 2021
Merged
robcamer
pushed a commit
to aztfmod/terratest
that referenced
this pull request
Jun 14, 2021
* feat: add AWS SSO support To support AWS SSO we need to Bump the AWS SDK which is providing support recently. Also we need to adjust our creation of sessins to include the `SharedConfigState` field. See https://aws.amazon.com/blogs/developer/aws-sso-support-in-the-aws-sdk-for-go/ for more information. * fix: gofmt * Limit parallelism due to aws-sdk-go failing Co-authored-by: Yoriyasu Yano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hej,
To support AWS SSO we need to Bump the AWS SDK which is providing
support recently.
Also we need to adjust our creation of sessions to include the
SharedConfigStatefield. Seehttps://aws.amazon.com/blogs/developer/aws-sso-support-in-the-aws-sdk-for-go/ for more information.
Cheers!