Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not need to call terraform get #880

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Should not need to call terraform get #880

merged 1 commit into from
Apr 29, 2021

Conversation

yorinasub17
Copy link
Contributor

Fixes #877

We should not have to make a call to GetE, as InitE should be sufficient to handle all the necessary initialization procedures.

@yorinasub17 yorinasub17 requested a review from brikis98 as a code owner April 27, 2021 18:21
@yorinasub17 yorinasub17 changed the title Should not neet to call terraform get Should not need to call terraform get Apr 27, 2021
brikis98
brikis98 approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging this in now!

@yorinasub17 yorinasub17 merged commit 862ec45 into master Apr 29, 2021
@yorinasub17 yorinasub17 deleted the yori-fix-get-calls branch April 29, 2021 16:56
This was referenced May 21, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brikis98 brikis98 brikis98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running InitAndPlanE will always update modules
2 participants
@yorinasub17 @brikis98