Update to Terraform 0.15 #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
commented
Apr 23, 2021
| @@ -1,3 +1,8 @@ | |||
| // +build azure | |||
There was a problem hiding this comment.
Missing build tag on our Azure code. Not related to this PR, but was causing test failures.
This ensures we always pick an instance type available in every AZ of our chosen AWS region
brikis98
commented
Apr 23, 2021
| @@ -26,7 +26,7 @@ provider "aws" { | |||
| resource "aws_launch_template" "sample_launch_template" { | |||
| name_prefix = var.instance_name | |||
| image_id = data.aws_ami.ubuntu.id | |||
| instance_type = "t2.micro" | |||
| instance_type = var.instance_type | |||
There was a problem hiding this comment.
This is not directly related to this PR, but we were getting intermittent test failures when we picked an instance type that happened not to be available in all AZs in an AWS region. To make tests more stable, I made these configurable, and used GetRecommendedInstanceType in our test code to pick a type that is available in all AZs.
|
OK, there is still a bit of test instability, but it's unrelated to this PR, and passed on re-run, and now all tests are passing! |
|
Thanks for the review! Merging now. |
This was referenced May 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Terratest build to run with Terraform 0.15.