Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression bug in helm.RenderTemplate where it leaks stderr #828

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Fix regression bug in helm.RenderTemplate where it leaks stderr #828

merged 1 commit into from
Mar 25, 2021

Conversation

yorinasub17
Copy link
Contributor

@yorinasub17 yorinasub17 requested a review from brikis98 as a code owner March 24, 2021 16:50
brikis98
brikis98 approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorinasub17
Copy link
Contributor Author

Thanks for review! Going to merge this in now.

@yorinasub17 yorinasub17 merged commit 44493a6 into master Mar 25, 2021
@yorinasub17 yorinasub17 deleted the yori-use-stdout branch March 25, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brikis98 brikis98 brikis98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yaml: mapping values are not allowed in this context
2 participants
@yorinasub17 @brikis98