Implement Terraform Workspace deletion. #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
changed the title
dduportal
force-pushed
the
feat/terraform_workspace_delete
branch
from
4b0b8b8 to
c00c498
Compare
|
Hello @brikis98 , thanks a lot for the review. I've updated the PR with a bunch of your feedbacks, but I need inputs on some. Please note that I haven't squashed the commits yet, in order to allow further update or rollback as necessary. |
Signed-off-by: Damien Duportal <[email protected]>
Co-authored-by: Yevgeniy Brikman <[email protected]>
dduportal
force-pushed
the
feat/terraform_workspace_delete
branch
from
5672783 to
c684c68
Compare
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
|
Ok, I've checked all your feedbacks, it should be ok (also rebased from upstream). Let me know if I missed something else. |
brikis98
approved these changes
Mar 24, 2021
|
Tests passed! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there 👋 Thanks for this awesoe tool.
This PR fixes #583 : it implements 2 methods to handle Terraform Workspace's deletion.
Please note that deleting the workspace
defaultis not supported as it triggers edgy use cases.