Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to hcl2 #790

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Update to hcl2 #790

merged 4 commits into from
Feb 23, 2021

Conversation

yorinasub17
Copy link
Contributor

Fixes #784

This updates the var-file.go routines to use hclv2 instead of hclv1. Note that this is a backwards incompatible change due to the change to make GetAllVariablesFromVarFileE more ergonomic for both the user and code maintenance.

modules/terraform/var-file.go Outdated Show resolved Hide resolved
modules/terraform/var-file.go Show resolved Hide resolved
modules/terraform/var-file.go Outdated Show resolved Hide resolved
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Yori!

@yorinasub17
Copy link
Contributor Author

Thanks for review! Test passed (except for GCP, which is not relevant to this PR), so going to merge this in now.

@yorinasub17 yorinasub17 merged commit 2114c22 into master Feb 23, 2021
@yorinasub17 yorinasub17 deleted the yori-fix-to-hcl2 branch February 23, 2021 19:07
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modules/terraform/var-file.go:142:8: undefined: hcl.Decode
2 participants