Fix broken link to test file in Azure AKS sample Readme #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infraredgirl
previously approved these changes
Feb 1, 2021
|
Looks like tests are currently unstable (unrelated to this change). We're working on a fix in #775. As soon as that is resolved, we can re-run the tests and merge this. Sorry for the delay! |
|
Hey @maniSbindra could you pull in the latest master here? #775 was merged so hopefully the tests should pass now. |
maniSbindra
force-pushed
the
manisbindra/fix-aks-sample-broken-test-file-link
branch
from
2ff137c to
408ba57
Compare
|
Hi @infraredgirl , Thanks, I have rebased from master and pulled in the commit |
|
Thanks! Running the tests now! |
infraredgirl
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
There's one test failing but it's obviously not related to this change. I'm going to go ahead and merge this. Thanks for the contribution and your patience @maniSbindra !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #773 .
Link to test file in Azure AKS Sample Readme is broken. This PR fixes the link.