Feature: enable Azure PostgreSQL Server testing #772
Conversation
|
@HadwaAbdelhalem PTAL |
There was a problem hiding this comment.
Thank you @omichels for your contribution. I left few comments on the PR/ also would you please execute the CI pipeline in your fork. #https://github.com/gruntwork-io/terratest/blob/master/.github/workflows/ci.yml.
|
|
||
| This folder contains a Terraform module that deploys resources in [Azure](https://azure.microsoft.com/) to demonstrate how you can use Terratest to write automated tests for your Azure Terraform code. | ||
| This module deploys a database for PostgreSQL. | ||
|
|
There was a problem hiding this comment.
Add a link to azure postgres database https://azure.microsoft.com/services/postgresql/ , not mysql
| 1. Install [Terraform](https://www.terraform.io/) and make sure it's on your `PATH` | ||
| 1. Configure your Terratest [Go test environment](../README.md) | ||
| 1. `cd test/azure` | ||
| 1. `go build terraform_azure_mysqldb_example_test.go` |
There was a problem hiding this comment.
fix to build the terraform_azure_postgresqldb_example_test.go
| # DEPLOY A RESOURCE GROUP | ||
| # --------------------------------------------------------------------------------------------------------------------- | ||
| resource "azurerm_resource_group" "rg" { | ||
| name = "postgresql-rg" |
There was a problem hiding this comment.
add location variable in variable.tf, then use it to set the location. see other azure samples for ref #
| geo_redundant_backup_enabled = false | ||
| auto_grow_enabled = true | ||
|
|
||
| administrator_login = "pgsqladmin" |
There was a problem hiding this comment.
please use random_password to create the administrator_login_password, See sample #
| } | ||
|
|
||
| output "servername" { | ||
| value = azurerm_postgresql_server.postgresqlserver.name |
|
|
||
| output "rgname" { | ||
| value = azurerm_resource_group.rg.name | ||
| } |
There was a problem hiding this comment.
add newline to the end of the file, consider running terraform fmt
There was a problem hiding this comment.
used terraform fmt
|
|
||
| // website::tag::4:: Get the Server details and assert them against the terraform output | ||
| actualServer := azure.GetPostgresqlServer(t, rgName, actualServername, subscriptionID) | ||
| // Verify |
There was a problem hiding this comment.
please assert the actualServer is not nil instead
|
|
||
| } | ||
|
|
||
| output "rgname" { |
There was a problem hiding this comment.
NIT: Please rename to "resource_group_name" and move to the top of the file
|
Hello. This PR is very useful for us so I would like to ask, is there any chance that this functionality will be accepted? |
There was a problem hiding this comment.
Thanks @omichels . @Jfmask yes, it is in final review phase . @yorinasub17 this is ready for your review
modules/azure/postgresql.go
Outdated
|
|
||
| // GetPostgresqlServer is a helper function that gets the server. | ||
| // This function would fail the test if there is an error. | ||
| func GetPostgresqlServer(t testing.TestingT, resGroupName string, serverName string, subscriptionID string) *postgresql.Server { |
There was a problem hiding this comment.
Can you make all the functions consistent and use PostgreSQL instead of Postgresql?
There was a problem hiding this comment.
@omichels could you please update the PR to resolve the last comment, or give me access to your repo and I would do it.
There was a problem hiding this comment.
"all functions consistent using PostgreSQL"
commit: 00727ae
There was a problem hiding this comment.
Tested and approved, @yorinasub17 ready for your final check.
No description provided.