Replace customerrors with go-multierror #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ana Krivokapić <[email protected]>
Co-authored-by: Ana Krivokapić <[email protected]>
Co-authored-by: Ana Krivokapić <[email protected]>
Co-authored-by: Ana Krivokapić <[email protected]>
Co-authored-by: Ana Krivokapić <[email protected]>
Co-authored-by: Ana Krivokapić <[email protected]>
|
Thanks for the suggestions @infraredgirl, I will keep them in mind. |
|
Thanks for the updates, Rohit! The code LGTM now, but tests seem to be failing. This could be due to some unrelated test instability we have hit lately. There's a PR open that should stabilize tests a bit, I'll wait for that to merge before merging this. Thanks for your patience! |
|
Thanks for the update, Ana. Sorry I saw your msg late. |
|
FYI - #765 is now merged. |
|
Thanks Rob! I re-ran the tests and the only failure is in helm tests which were not affected by this change. I'll go ahead and merge - thanks again for the contribution @urohit011 ! |
infraredgirl
approved these changes
Jan 22, 2021
|
Thank you Ana and Rob :) |
helayoty
pushed a commit
to helayoty/terratest
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #751 by replacing the use of customerrors with go-multierror
Link to test result gist -> gist
The test github.com/gruntwork-io/terratest/test/terraform_scp_example_test.go fails, but it does not look like it's due to the change in this commit.