feat: adding Azure Log Analytics module #639
Conversation
…rratest into pull-request-632
| # --------------------------------------------------------------------------------------------------------------------- | ||
|
|
||
| resource "azurerm_resource_group" "resource_group" { | ||
| name = "${var.resource_group_basename}-${var.postfix}" |
There was a problem hiding this comment.
switch "${var.resource_group_basename}-${var.postfix}" to "terratest-rg-${var.postfix}"
examples/azure/terraform-azure-loganalytics-example/variables.tf
Outdated
Show resolved
Hide resolved
modules/azure/loganalytics.go
Outdated
| return false | ||
| } | ||
|
|
||
| return (*ws.Name == workspaceName) |
There was a problem hiding this comment.
need to handle when workspace name is invalid. Please follow pattern in AvailabilitySet
@davesee
|
[Microsoft CI Bot] TL;DR; success 👍 You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/550467385 |
There was a problem hiding this comment.
LGTM! Found one missing docs, and https://github.com/gruntwork-io/terratest/pull/639/files#r502750578 still needs to be addressed.
modules/azure/loganalytics.go
Outdated
| return string(sku) | ||
| } | ||
|
|
||
| func GetLogAnalyticsWorkspaceSkuE(workspaceName string, resourceGroupName string, subscriptionID string) (string, error) { |
There was a problem hiding this comment.
NIT: this function needs docs comment.
|
[Microsoft CI Bot] TL;DR; failure 🤦 You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/559081496 |
|
[Microsoft CI Bot] TL;DR; failure 🤦 You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/559081496 |
|
[Microsoft CI Bot] TL;DR; success 👍 You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/559081496 |
|
@yorinasub17 PR is updated to address the comments. Please review when you have a chance |
#632
Azure loganalytics module for terratest with the following:
(i) Terraform example is examples/azure folder
(ii) loganalytics modules in modules/azure folder
(iii) unit test in test/azure folder
(iv) integration test with example in test/azure folder